Hi @kostya-gromov!

Thank you for your pull request and welcome to our community.

Action Required

In order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you.

Process

In order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA.

Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with CLA signed. The tagging process may take up to 1 hour after signing. Please give it that time before contacting us about it.

If you have received this in error or have any questions, please contact us at [email protected]. Thanks!

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Meta Open Source project. Thanks!

Thanks for your interest in contributing! This is overly broad so we won't be able to use this approach. The right fix is to promote the LoadGlobal to a jsx temporary

Hey @josephsavona,
Thank you for the review!

I’ve pushed another commit with the updated changes.
This is my first contribution to React, so please let me know if I’m still missing something — I really appreciate your guidance.

My apologies, we're getting a lot of AI-generated spam PRs and I didn't provide a proper reply here. Rather than do the promotion in ConstantPropagation — which isn't that pass's concern — we already have the PromoteUsedTemporaries pass which is intended to handle this case. It looks like we're just not considering lvalues for promotion in that pass. That would be the place to explore adding a fix.